src: remove OnScopeLeaveImpl's move assignment overload · nodejs/node@07d0fd6 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 761
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 07d0fd6

Browse filesBrowse the repository at this point in the historyBrowse files

CGQAQ

authored and

RafaelGSS

committed

src: remove OnScopeLeaveImpl's move assignment overload

... as it's not valid implementation and also has not been used PR-URL: #48732 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 41cc3ef commit 07d0fd6
Copy full SHA for 07d0fd6

1 file changed

-6Lines changed: 0 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • util.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/util.h‎

Copy file name to clipboardExpand all lines: src/util.h

-6Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -577,12 +577,6 @@ struct OnScopeLeaveImpl {
577	577	: fn_(std::move(other.fn_)), active_(other.active_) {
578	578	other.active_ = false;
579	579	}
580		- OnScopeLeaveImpl& operator=(OnScopeLeaveImpl&& other) {
581		- if (this == &other) return *this;
582		- this->~OnScopeLeave();
583		- new (this)OnScopeLeaveImpl(std::move(other));
584		- return *this;
585		- }
586	580	};
587	581
588	582	// Run a function when exiting the current scope. Used like this:

0 commit comments

Comments

0 (0)