Commit 07de4ed
src: do not ignore return value of BIO_reset
The USE macro indicates that a value is intentionally ignored. Instead,
CHECK that the function succeeds.
PR-URL: #42103
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent 3366618 commit 07de4ed
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -298,7 +298,7 @@ Local<Value> ToV8Value(Environment* env, const BIOPointer& bio) { | |||
| 298 | 298 | mem->data, | |
| 299 | 299 | NewStringType::kNormal, | |
| 300 | 300 | mem->length); | |
| 301 | - USE(BIO_reset(bio.get())); | ||
| 301 | + CHECK_EQ(BIO_reset(bio.get()), 1); | ||
| 302 | 302 | return ret.FromMaybe(Local<Value>()); | |
| 303 | 303 | } | |
| 304 | 304 | ||
@@ -951,7 +951,7 @@ v8::MaybeLocal<v8::Value> GetSubjectAltNameString( | |||
| 951 | 951 | CHECK_NOT_NULL(ext); | |
| 952 | 952 | ||
| 953 | 953 | if (!SafeX509SubjectAltNamePrint(bio, ext)) { | |
| 954 | - USE(BIO_reset(bio.get())); | ||
| 954 | + CHECK_EQ(BIO_reset(bio.get()), 1); | ||
| 955 | 955 | return v8::Null(env->isolate()); | |
| 956 | 956 | } | |
| 957 | 957 | ||
@@ -970,7 +970,7 @@ v8::MaybeLocal<v8::Value> GetInfoAccessString( | |||
| 970 | 970 | CHECK_NOT_NULL(ext); | |
| 971 | 971 | ||
| 972 | 972 | if (!SafeX509InfoAccessPrint(bio, ext)) { | |
| 973 | - USE(BIO_reset(bio.get())); | ||
| 973 | + CHECK_EQ(BIO_reset(bio.get()), 1); | ||
| 974 | 974 | return v8::Null(env->isolate()); | |
| 975 | 975 | } | |
| 976 | 976 | ||
@@ -987,7 +987,7 @@ MaybeLocal<Value> GetIssuerString( | |||
| 987 | 987 | issuer_name, | |
| 988 | 988 | 0, | |
| 989 | 989 | kX509NameFlagsMultiline) <= 0) { | |
| 990 | - USE(BIO_reset(bio.get())); | ||
| 990 | + CHECK_EQ(BIO_reset(bio.get()), 1); | ||
| 991 | 991 | return Undefined(env->isolate()); | |
| 992 | 992 | } | |
| 993 | 993 | ||
@@ -1003,7 +1003,7 @@ MaybeLocal<Value> GetSubject( | |||
| 1003 | 1003 | X509_get_subject_name(cert), | |
| 1004 | 1004 | 0, | |
| 1005 | 1005 | kX509NameFlagsMultiline) <= 0) { | |
| 1006 | - USE(BIO_reset(bio.get())); | ||
| 1006 | + CHECK_EQ(BIO_reset(bio.get()), 1); | ||
| 1007 | 1007 | return Undefined(env->isolate()); | |
| 1008 | 1008 | } | |
| 1009 | 1009 | ||
0 commit comments