Commit 07ffa3f
build: add check for empty openssl-fips flag
Currently, when specifying the --openssl-fips flag without any path
, or an empty path, does not generate an error. If a path is specified
then the following error is generated:
ERROR: FIPS is not supported in this version of Node.js
This commit adds a check so that the error is generated even if the
path is empty.
PR-URL: #25391
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent fe9b6ee commit 07ffa3f
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1238,7 +1238,7 @@ def without_ssl_error(option): | |||
| 1238 | 1238 | if options.openssl_no_asm and options.shared_openssl: | |
| 1239 | 1239 | error('--openssl-no-asm is incompatible with --shared-openssl') | |
| 1240 | 1240 | ||
| 1241 | - if options.openssl_fips: | ||
| 1241 | + if options.openssl_fips or options.openssl_fips == '': | ||
| 1242 | 1242 | error('FIPS is not supported in this version of Node.js') | |
| 1243 | 1243 | ||
| 1244 | 1244 | configure_library('openssl', o) | |
0 commit comments