Commit 086ee5e
test: increase coverage of internal/stream/end-of-stream
This change adds test cases to call the function returned by
end-of-stream and asserts that callbacks are not called when
the stream is ended, or prematurely closed.
PR-URL: #23751
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 1baba9b commit 086ee5e
1 file changed
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -153,3 +153,25 @@ const { promisify } = require('util'); | |||
| 153 | 153 | rs.push(null); | |
| 154 | 154 | rs.resume(); | |
| 155 | 155 | } | |
| 156 | + | ||
| 157 | + // Test that calling returned function removes listeners | ||
| 158 | + { | ||
| 159 | + const ws = new Writable({ | ||
| 160 | + write(data, env, cb) { | ||
| 161 | + cb(); | ||
| 162 | + } | ||
| 163 | + }); | ||
| 164 | + const removeListener = finished(ws, common.mustNotCall()); | ||
| 165 | + removeListener(); | ||
| 166 | + ws.end(); | ||
| 167 | + } | ||
| 168 | + | ||
| 169 | + { | ||
| 170 | + const rs = new Readable(); | ||
| 171 | + const removeListeners = finished(rs, common.mustNotCall()); | ||
| 172 | + removeListeners(); | ||
| 173 | + | ||
| 174 | + rs.emit('close'); | ||
| 175 | + rs.push(null); | ||
| 176 | + rs.resume(); | ||
| 177 | + } | ||
0 commit comments