lib: fix module print timing when specifier includes `"` · nodejs/node@08b5e6c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 08b5e6c

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

committed

lib: fix module print timing when specifier includes "

PR-URL: #55150 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

1 parent 85b7659 commit 08b5e6c
Copy full SHA for 08b5e6c

2 files changed

+11-2Lines changed: 11 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/util
  • debuglog.js
• test/parallel
  • test-module-print-timing.mjs

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/util/debuglog.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/debuglog.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -173,7 +173,7 @@ function formatTime(ms) {
173	173	}
174	174
175	175	function safeTraceLabel(label) {
176		- return label.replace(/\\/g, '\\\\');
	176	+ return label.replace(/\\/g, '\\\\').replaceAll('"', '\\"');
177	177	}
178	178
179	179	/**

Collapse file

‎test/parallel/test-module-print-timing.mjs‎

Copy file name to clipboardExpand all lines: test/parallel/test-module-print-timing.mjs

+10-1Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,5 +1,6 @@
1		- import '../common/index.mjs';
	1	+ import { isWindows } from '../common/index.mjs';
2	2	import assert from 'node:assert';
	3	+ import { writeFileSync } from 'node:fs';
3	4	import { readFile } from 'node:fs/promises';
4	5	import { it } from 'node:test';
5	6	import tmpdir from '../common/tmpdir.js';
@@ -113,11 +114,19 @@ it('should support enable tracing dynamically', async () => {
113	114
114	115
115	116	const outputFile = tmpdir.resolve('output-dynamic-trace.log');
	117	+ let requireFileWithDoubleQuote = '';
	118	+ if (!isWindows) {
	119	+ // Double quotes are not valid char for a path on Windows.
	120	+ const fileWithDoubleQuote = tmpdir.resolve('filename-with-"double"-quotes.cjs');
	121	+ writeFileSync(fileWithDoubleQuote, ';\n');
	122	+ requireFileWithDoubleQuote = `require(${JSON.stringify(fileWithDoubleQuote)});`;
	123	+ }
116	124	const jsScript = `
117	125	const traceEvents = require("trace_events");
118	126	const tracing = traceEvents.createTracing({ categories: ["node.module_timer"] });
119	127
120	128	tracing.enable();
	129	+ ${requireFileWithDoubleQuote}
121	130	require("http");
122	131	tracing.disable();
123	132

0 commit comments

Comments

0 (0)