Commit 08e12c7
src: remove superfluous env_string string
It's only used once at startup in a single place so create the string
in place instead of caching it for the lifetime of the isolate.
PR-URL: #9213
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent c342bda commit 08e12c7
2 files changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -93,7 +93,6 @@ namespace node { | |||
| 93 | 93 | V(encoding_string, "encoding") \ | |
| 94 | 94 | V(enter_string, "enter") \ | |
| 95 | 95 | V(env_pairs_string, "envPairs") \ | |
| 96 | - V(env_string, "env") \ | ||
| 97 | 96 | V(errno_string, "errno") \ | |
| 98 | 97 | V(error_string, "error") \ | |
| 99 | 98 | V(events_string, "_events") \ | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3157,7 +3157,7 @@ void SetupProcessObject(Environment* env, | |||
| 3157 | 3157 | env->as_external()); | |
| 3158 | 3158 | Local<Object> process_env = | |
| 3159 | 3159 | process_env_template->NewInstance(env->context()).ToLocalChecked(); | |
| 3160 | - process->Set(env->env_string(), process_env); | ||
| 3160 | + process->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "env"), process_env); | ||
| 3161 | 3161 | ||
| 3162 | 3162 | READONLY_PROPERTY(process, "pid", Integer::New(env->isolate(), getpid())); | |
| 3163 | 3163 | READONLY_PROPERTY(process, "features", GetFeatures(env)); | |
0 commit comments