tools: restrict internal code from using public `url` module · nodejs/node@08ffc63 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 08ffc63

Browse filesBrowse the repository at this point in the historyBrowse files

LiviaMedeiros

authored and

ruyadorno

committed

tools: restrict internal code from using public url module

PR-URL: #49590 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 6fcb51d commit 08ffc63
Copy full SHA for 08ffc63

2 files changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • .eslintrc.yaml
  • internal/bootstrap/switches
    • is_main_thread.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/.eslintrc.yaml‎

Copy file name to clipboardExpand all lines: lib/.eslintrc.yaml

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -175,6 +175,10 @@ rules:
175	175	message: Use `const { structuredClone } = require('internal/structured_clone');` instead of the global.
176	176	- name: SubtleCrypto
177	177	message: Use `const { SubtleCrypto } = require('internal/crypto/webcrypto');` instead of the global.
	178	+ no-restricted-modules:
	179	+ - error
	180	+ - name: url
	181	+ message: Require `internal/url` instead of `url`.
178	182	# Custom rules in tools/eslint-rules
179	183	node-core/avoid-prototype-pollution: error
180	184	node-core/lowercase-name-for-primitive: error

Collapse file

‎lib/internal/bootstrap/switches/is_main_thread.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/switches/is_main_thread.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -290,7 +290,7 @@ rawMethods.resetStdioForTesting = function() {
290	290	// Needed by the module loader and generally needed everywhere.
291	291	require('fs');
292	292	require('util');
293		- require('url');
	293	+ require('url'); // eslint-disable-line no-restricted-modules
294	294
295	295	require('internal/modules/cjs/loader');
296	296	require('internal/modules/esm/utils');

0 commit comments

Comments

0 (0)