Commit 0931f7e
build: fix icu-i18n pkg-config version check
The pkg_config() helper can either return a tuple of None values
(no pkg-config installed) and that was what the check was testing
for, but it can also return a tuple of empty strings when the
package isn't installed.
PR-URL: #28118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent e2ad364 commit 0931f7e
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1348,7 +1348,7 @@ def write_config(data, name): | |||
| 1348 | 1348 | # ICU from pkg-config. | |
| 1349 | 1349 | o['variables']['v8_enable_i18n_support'] = 1 | |
| 1350 | 1350 | pkgicu = pkg_config('icu-i18n') | |
| 1351 | - if pkgicu[0] is None: | ||
| 1351 | + if not pkgicu[0]: | ||
| 1352 | 1352 | error('''Could not load pkg-config data for "icu-i18n". | |
| 1353 | 1353 | See above errors or the README.md.''') | |
| 1354 | 1354 | (libs, cflags, libpath, icuversion) = pkgicu | |
0 commit comments