Commit 094bfe6
build: fix node_g target
Currently when running make node_g the following error is displayed:
if [ ! -r node -o ! -L ]; then ln -fs out/Debug/node node_g; fi
/bin/sh: line 0: [: argument expected
It looks like there was a typo for the NODE_EXE where node became
lowercase instead of uppercase.
Ref: #9827
PR-URL: #10153
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>1 parent 87db4f7 commit 094bfe6
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -67,11 +67,11 @@ endif | |||
| 67 | 67 | # See comments on the build-addons target for some more info | |
| 68 | 68 | $(NODE_EXE): config.gypi out/Makefile | |
| 69 | 69 | $(MAKE) -C out BUILDTYPE=Release V=$(V) | |
| 70 | - if [ ! -r $(NODE_EXE) -o ! -L $(NODE_EXE) ]; then ln -fs out/Release/$(NODE_EXE) $@; fi | ||
| 70 | + if [ ! -r $@ -o ! -L $@ ]; then ln -fs out/Release/$(NODE_EXE) $@; fi | ||
| 71 | 71 | ||
| 72 | 72 | $(NODE_G_EXE): config.gypi out/Makefile | |
| 73 | 73 | $(MAKE) -C out BUILDTYPE=Debug V=$(V) | |
| 74 | - if [ ! -r $(NODE_EXE) -o ! -L $(node_EXE) ]; then ln -fs out/Debug/$(NODE_EXE) $@; fi | ||
| 74 | + if [ ! -r $@ -o ! -L $@ ]; then ln -fs out/Debug/$(NODE_EXE) $@; fi | ||
| 75 | 75 | ||
| 76 | 76 | out/Makefile: common.gypi deps/uv/uv.gyp deps/http_parser/http_parser.gyp deps/zlib/zlib.gyp deps/v8/build/toolchain.gypi deps/v8/build/features.gypi deps/v8/tools/gyp/v8.gyp node.gyp config.gypi | |
| 77 | 77 | $(PYTHON) tools/gyp_node.py -f make | |
0 commit comments