sqlite: fix undefined behaviour in `Session::Changeset()` · nodejs/node@09d0da9 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 09d0da9

Browse filesBrowse the repository at this point in the historyBrowse files

ndossche

authored and

aduh95

committed

sqlite: fix undefined behaviour in Session::Changeset()

If `nChangeset == 0`, the pointer `pChangeset` may be nullptr. Passing a nullptr to `memcpy()` is undefined behaviour. This can be triggered by running the test suite under UBSAN. Signed-off-by: ndossche <nora.dossche@ugent.be> PR-URL: #63637 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>

1 parent 58ea88e commit 09d0da9
Copy full SHA for 09d0da9

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_sqlite.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_sqlite.cc‎

Copy file name to clipboardExpand all lines: src/node_sqlite.cc

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -3936,7 +3936,9 @@ void Session::Changeset(const FunctionCallbackInfo<Value>& args) {
3936	3936	auto freeChangeset = OnScopeLeave([&] { sqlite3_free(pChangeset); });
3937	3937
3938	3938	Local<ArrayBuffer> buffer = ArrayBuffer::New(env->isolate(), nChangeset);
3939		- std::memcpy(buffer->GetBackingStore()->Data(), pChangeset, nChangeset);
	3939	+ if (nChangeset > 0) {
	3940	+ std::memcpy(buffer->GetBackingStore()->Data(), pChangeset, nChangeset);
	3941	+ }
3940	3942	Local<Uint8Array> uint8Array = Uint8Array::New(buffer, 0, nChangeset);
3941	3943
3942	3944	args.GetReturnValue().Set(uint8Array);

0 commit comments

Comments

0 (0)