lib: avoid for of loop and remove unnecessary variable in zlib · nodejs/node@09f411e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 09f411e

Browse filesBrowse the repository at this point in the historyBrowse files

MCprotein

authored and

targos

committed

lib: avoid for of loop and remove unnecessary variable in zlib

removed the unnecessary declaration of 'i' in the _final method scope and changed the for of loop to a for loop Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration PR-URL: #54258 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1 parent 6f4b5d9 commit 09f411e
Copy full SHA for 09f411e

1 file changed

+2-3Lines changed: 2 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • zlib.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/zlib.js‎

Copy file name to clipboardExpand all lines: lib/zlib.js

+2-3Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -361,11 +361,10 @@ ZlibBase.prototype._final = function(callback) {
361	361	// Z_NO_FLUSH (< Z_TREES) < Z_BLOCK < Z_PARTIAL_FLUSH <
362	362	// Z_SYNC_FLUSH < Z_FULL_FLUSH < Z_FINISH
363	363	const flushiness = [];
364		- let i = 0;
365	364	const kFlushFlagList = [Z_NO_FLUSH, Z_BLOCK, Z_PARTIAL_FLUSH,
366	365	Z_SYNC_FLUSH, Z_FULL_FLUSH, Z_FINISH];
367		- for (const flushFlag of kFlushFlagList) {
368		- flushiness[flushFlag] = i++;
	366	+ for (let i = 0; i < kFlushFlagList.length; i++) {
	367	+ flushiness[kFlushFlagList[i]] = i;
369	368	}
370	369
371	370	function maxFlush(a, b) {

0 commit comments

Comments

0 (0)