util: use `primordials.ArrayPrototypeIndexOf` instead of mutable method · nodejs/node@0a022c4 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0a022c4

Browse filesBrowse the repository at this point in the historyBrowse files

DaisyDogs07

authored and

ruyadorno

committed

util: use primordials.ArrayPrototypeIndexOf instead of mutable method

PR-URL: #48586 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent d3041df commit 0a022c4
Copy full SHA for 0a022c4

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/util
  • inspect.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/util/inspect.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/inspect.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1216,7 +1216,7 @@ function getFunctionBase(value, constructor, tag) {
1216	1216	function identicalSequenceRange(a, b) {
1217	1217	for (let i = 0; i < a.length - 3; i++) {
1218	1218	// Find the first entry of b that matches the current entry of a.
1219		- const pos = b.indexOf(a[i]);
	1219	+ const pos = ArrayPrototypeIndexOf(b, a[i]);
1220	1220	if (pos !== -1) {
1221	1221	const rest = b.length - pos;
1222	1222	if (rest > 3) {

0 commit comments

Comments

0 (0)