Commit 0a2a39c
doc: explains why Reviewed-By is added in PRs
Adds verbose reasons to the documentation on why the
Reviewed-By metadata on a pull request is important.
This was loosely mentioned as an issue in the referenced
issue below, and answered by @addaleax.
Ref: #8893
PR-URL: #9044
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 3af679e commit 0a2a39c
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -101,6 +101,8 @@ information regarding the change process: | |||
| 101 | 101 | ||
| 102 | 102 | - A `Reviewed-By: Name <email>` line for yourself and any | |
| 103 | 103 | other Collaborators who have reviewed the change. | |
| 104 | + - Useful for @mentions / contact list if something goes wrong in the PR. | ||
| 105 | + - Protects against the assumption that GitHub will be around forever. | ||
| 104 | 106 | - A `PR-URL:` line that references the *full* GitHub URL of the original | |
| 105 | 107 | pull request being merged so it's easy to trace a commit back to the | |
| 106 | 108 | conversation that led up to that change. | |
0 commit comments