test: forbid `common.mustCall*()` in process exit handlers · nodejs/node@0ade488 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0ade488

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

MylesBorins

committed

test: forbid common.mustCall*() in process exit handlers

`common.mustCall()` and `common.mustCallAtLeast()` need to be called before process exit handlers to work because checks are done inside a process exit handler. Detect if being used inside a process exit handler and throw. PR-URL: #17453 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 85e6271 commit 0ade488
Copy full SHA for 0ade488

1 file changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/common
  • index.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -493,6 +493,8 @@ exports.mustCallAtLeast = function(fn, minimum) {
493	493	};
494	494
495	495	function _mustCallInner(fn, criteria = 1, field) {
	496	+ if (process._exiting)
	497	+ throw new Error('Cannot use common.mustCall*() in process exit handler');
496	498	if (typeof fn === 'number') {
497	499	criteria = fn;
498	500	fn = noop;

0 commit comments

Comments

0 (0)