async_hooks: improve property descriptors in als.bind · nodejs/node@0af9bee · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0af9bee

Browse filesBrowse the repository at this point in the historyBrowse files

Flarna

authored and

addaleax

committed

async_hooks: improve property descriptors in als.bind

The length property should be non enumerable to match behavior of normal functions. The asyncResource property is enumerable and therefore it should be also writable to avoid issues like there: #30932 (comment) Both properties should be configurable. Refs: #34574 PR-URL: #34620 Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 16aa927 commit 0af9bee
Copy full SHA for 0af9bee

1 file changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • async_hooks.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/async_hooks.js‎

Copy file name to clipboardExpand all lines: lib/async_hooks.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -220,12 +220,16 @@ class AsyncResource {
220	220	const ret = this.runInAsyncScope.bind(this, fn);
221	221	ObjectDefineProperties(ret, {
222	222	'length': {
223		- enumerable: true,
	223	+ configurable: true,
	224	+ enumerable: false,
224	225	value: fn.length,
	226	+ writable: false,
225	227	},
226	228	'asyncResource': {
	229	+ configurable: true,
227	230	enumerable: true,
228	231	value: this,
	232	+ writable: true,
229	233	}
230	234	});
231	235	return ret;

0 commit comments

Comments

0 (0)