Commit 0b5798b
src: remove outdated todo from node_crypto.cc
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.
PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 5522bdf commit 0b5798b
1 file changed
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1607,7 +1607,6 @@ static Local<Object> X509ToObject(Environment* env, X509* cert) { | |||
| 1607 | 1607 | const char hex[] = "0123456789ABCDEF"; | |
| 1608 | 1608 | char fingerprint[EVP_MAX_MD_SIZE * 3]; | |
| 1609 | 1609 | ||
| 1610 | - // TODO(indutny): Unify it with buffer's code | ||
| 1611 | 1610 | for (i = 0; i < md_size; i++) { | |
| 1612 | 1611 | fingerprint[3*i] = hex[(md[i] & 0xf0) >> 4]; | |
| 1613 | 1612 | fingerprint[(3*i)+1] = hex[(md[i] & 0x0f)]; | |
0 commit comments