buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength · nodejs/node@0bd78dc · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0bd78dc

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

targos

committed

buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength

This was added in v8 6.2, looks like a safe replacement for our own buffer::kMaxLength. PR-URL: #19738 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 0127712 commit 0bd78dc
Copy full SHA for 0bd78dc

1 file changed

+1-2Lines changed: 1 addition & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_buffer.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_buffer.h‎

Copy file name to clipboardExpand all lines: src/node_buffer.h

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -31,8 +31,7 @@ extern bool zero_fill_all_buffers;
31	31
32	32	namespace Buffer {
33	33
34		- static const unsigned int kMaxLength =
35		- sizeof(int32_t) == sizeof(intptr_t) ? 0x3fffffff : 0x7fffffff;
	34	+ static const unsigned int kMaxLength = v8::TypedArray::kMaxLength;
36	35
37	36	typedef void (*FreeCallback)(char* data, void* hint);
38	37

0 commit comments

Comments

0 (0)