Commit 0c24b91
src: fix error handling in ExportJWKAsymmetricKey
Because call sites check IsNothing() on the return value of
ExportJWKAsymmetricKey() and ignore the boolean value if the return
value is Just (i.e., not nothing), this function must return Nothing()
instead of Just(false) when throwing a JavaScript error.
PR-URL: #53767
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 2a2620e commit 0c24b91
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -505,7 +505,7 @@ Maybe<bool> ExportJWKAsymmetricKey( | |||
| 505 | 505 | case EVP_PKEY_X448: return ExportJWKEdKey(env, key, target); | |
| 506 | 506 | } | |
| 507 | 507 | THROW_ERR_CRYPTO_JWK_UNSUPPORTED_KEY_TYPE(env); | |
| 508 | - return Just(false); | ||
| 508 | + return Nothing<bool>(); | ||
| 509 | 509 | } | |
| 510 | 510 | ||
| 511 | 511 | std::shared_ptr<KeyObjectData> ImportJWKAsymmetricKey( | |
0 commit comments