Commit 0ca8044
test: make test-os-checked-function work without test harness
Most tests in `test/parallel` work when invoked with `node` rather than
`tools/test.py` but not test-os-checked-function because it doesn't load
the `common` module initially, which means it won't get re-spawned with
the necessary flags (in the Flags: comment, in this case
--expose_internals). Now that common delays loading 'os' until it needs
to load it, this test can load the common module and it will work from
the command line without the test harness. Additionally, we now can
remove a comment disabling a lint rule.
PR-URL: #30914
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>1 parent 20c8a0a commit 0ca8044
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,7 @@ | |||
| 1 | - /* eslint-disable node-core/require-common-first */ | ||
| 2 | 1 | 'use strict'; | |
| 3 | 2 | // Flags: --expose_internals | |
| 4 | 3 | ||
| 4 | + const common = require('../common'); | ||
| 5 | 5 | const { internalBinding } = require('internal/test/binding'); | |
| 6 | 6 | ||
| 7 | 7 | // Monkey patch the os binding before requiring any other modules, including | |
@@ -12,7 +12,6 @@ internalBinding('os').getHomeDirectory = function(ctx) { | |||
| 12 | 12 | ctx.message = 'baz'; | |
| 13 | 13 | }; | |
| 14 | 14 | ||
| 15 | - const common = require('../common'); | ||
| 16 | 15 | const os = require('os'); | |
| 17 | 16 | ||
| 18 | 17 | common.expectsError(os.homedir, { | |
0 commit comments