Commit 0d25d05
test: test hmac binding robustness
The Hmac binding layer is not documented as part of the API, and is not
intended to be used, but it should be robust to misuse, and contains
defensive checks for misuse. This test checks that updates without init
throw (as opposed to abort or misbehave in some other way).
PR-URL: #10923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 1307104 commit 0d25d05
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,6 +8,14 @@ if (!common.hasCrypto) { | |||
| 8 | 8 | } | |
| 9 | 9 | var crypto = require('crypto'); | |
| 10 | 10 | ||
| 11 | + // Test for binding layer robustness | ||
| 12 | + { | ||
| 13 | + const binding = process.binding('crypto'); | ||
| 14 | + const h = new binding.Hmac(); | ||
| 15 | + // Fail to init the Hmac with an algorithm. | ||
| 16 | + assert.throws(() => h.update('hello'), /^TypeError: HmacUpdate fail$/); | ||
| 17 | + } | ||
| 18 | + | ||
| 11 | 19 | // Test HMAC | |
| 12 | 20 | var h1 = crypto.createHmac('sha1', 'Node') | |
| 13 | 21 | .update('some data') | |
0 commit comments