lib: optimize copyError with ObjectAssign in primordials · nodejs/node@0d70c79 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0d70c79

Browse filesBrowse the repository at this point in the historyBrowse files

rayark1

authored and

marco-ippolito

committed

lib: optimize copyError with ObjectAssign in primordials

optimized the copyError function by using ObjectAssign from primordials. this change replaces the for-loop with ObjectAssign, which improves memory usage and performance. this change updates the copyError function in internal/assert.js to use ObjectAssign for copying properties. PR-URL: #53999 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

1 parent bfabfb4 commit 0d70c79
Copy full SHA for 0d70c79

1 file changed

+2-6Lines changed: 2 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/assert
  • assertion_error.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/assert/assertion_error.js‎

Copy file name to clipboardExpand all lines: lib/internal/assert/assertion_error.js

+2-6Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -6,9 +6,9 @@ const {
6	6	Error,
7	7	ErrorCaptureStackTrace,
8	8	MathMax,
	9	+ ObjectAssign,
9	10	ObjectDefineProperty,
10	11	ObjectGetPrototypeOf,
11		- ObjectKeys,
12	12	String,
13	13	StringPrototypeEndsWith,
14	14	StringPrototypeRepeat,
@@ -46,11 +46,7 @@ const kReadableOperator = {
46	46	const kMaxShortLength = 12;
47	47
48	48	function copyError(source) {
49		- const keys = ObjectKeys(source);
50		- const target = { __proto__: ObjectGetPrototypeOf(source) };
51		- for (const key of keys) {
52		- target[key] = source[key];
53		- }
	49	+ const target = ObjectAssign({ __proto__: ObjectGetPrototypeOf(source) }, source);
54	50	ObjectDefineProperty(target, 'message', { __proto__: null, value: source.message });
55	51	return target;
56	52	}

0 commit comments

Comments

0 (0)