Commit 0dec568
fs: remove broken code in promises/write
That code expects the last argument to be a callback.
When it's not a callback, it shifts arguments, defaulting
encoding to 'utf-8', which is clearly broken.
Old signature: (fd, string[, position[, encoding]], callback)
New signature: (fd, string[, position[, encoding]])
PR-URL: #20407
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jamie Davis <davisjam@vt.edu>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>1 parent b172f6b commit 0dec568
1 file changed
Lines changed: 0 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -242,15 +242,6 @@ async function write(handle, buffer, offset, length, position) { | |||
| 242 | 242 | ||
| 243 | 243 | if (typeof buffer !== 'string') | |
| 244 | 244 | buffer += ''; | |
| 245 | - if (typeof position !== 'function') { | ||
| 246 | - if (typeof offset === 'function') { | ||
| 247 | - position = offset; | ||
| 248 | - offset = null; | ||
| 249 | - } else { | ||
| 250 | - position = length; | ||
| 251 | - } | ||
| 252 | - length = 'utf8'; | ||
| 253 | - } | ||
| 254 | 245 | const bytesWritten = (await binding.writeString(handle.fd, buffer, offset, | |
| 255 | 246 | length, kUsePromises)) || 0; | |
| 256 | 247 | return { bytesWritten, buffer }; | |
0 commit comments