test: test mode passed as an options object in mkdir/mkdirSync · nodejs/node@0e1963c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0e1963c

Browse filesBrowse the repository at this point in the historyBrowse files

RaisinTen

authored and

targos

committed

test: test mode passed as an options object in mkdir/mkdirSync

Add tests for mode passed as an options object in fs.mkdir() and fs.mkdirSync(). This also adds coverage for mkdirSync() inside the conditional where options.mode is not undefined. PR-URL: #37008 Refs: https://coverage.nodejs.org/coverage-e3e054d020ee5ef6/lib/fs.js.html#L1023 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent a1ee9b3 commit 0e1963c
Copy full SHA for 0e1963c

1 file changed

+19Lines changed: 19 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-fs-mkdir.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-fs-mkdir.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-mkdir.js

+19Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -53,6 +53,25 @@ function nextdir() {
53	53	}));
54	54	}
55	55
	56	+ // fs.mkdir creates directory with mode passed as an options object
	57	+ {
	58	+ const pathname = path.join(tmpdir.path, nextdir());
	59	+
	60	+ fs.mkdir(pathname, { mode: 0o777 }, common.mustCall(function(err) {
	61	+ assert.strictEqual(err, null);
	62	+ assert.strictEqual(fs.existsSync(pathname), true);
	63	+ }));
	64	+ }
	65	+
	66	+ // fs.mkdirSync creates directory with mode passed as an options object
	67	+ {
	68	+ const pathname = path.join(tmpdir.path, nextdir());
	69	+
	70	+ fs.mkdirSync(pathname, { mode: 0o777 });
	71	+
	72	+ assert.strictEqual(fs.existsSync(pathname), true);
	73	+ }
	74	+
56	75	// mkdirSync successfully creates directory from given path
57	76	{
58	77	const pathname = path.join(tmpdir.path, nextdir());

0 commit comments

Comments

0 (0)