Commit 0ef6e04
win: allow skipping the supported platform check
Fixes: #33034
PR-URL: #33176
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 0b34c4f commit 0ef6e04
3 files changed
Lines changed: 31 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1345,6 +1345,15 @@ added: | |||
| 1345 | 1345 | Path to a Node.js module which will be loaded in place of the built-in REPL. | |
| 1346 | 1346 | Overriding this value to an empty string (`''`) will use the built-in REPL. | |
| 1347 | 1347 | ||
| 1348 | + ### `NODE_SKIP_PLATFORM_CHECK=value` | ||
| 1349 | + <!-- YAML | ||
| 1350 | + added: REPLACEME | ||
| 1351 | + --> | ||
| 1352 | + | ||
| 1353 | + If `value` equals `'1'`, the check for a supported platform is skipped during | ||
| 1354 | + Node.js startup. Node.js might not execute correctly. Any issues encountered | ||
| 1355 | + on unsupported platforms will not be fixed. | ||
| 1356 | + | ||
| 1348 | 1357 | ### `NODE_TLS_REJECT_UNAUTHORIZED=value` | |
| 1349 | 1358 | ||
| 1350 | 1359 | If `value` equals `'0'`, certificate validation is disabled for TLS connections. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -565,6 +565,13 @@ The default path is | |||
| 565 | 565 | which is overridden by this variable. | |
| 566 | 566 | Setting the value to an empty string ("" or " ") will disable persistent REPL history. | |
| 567 | 567 | . | |
| 568 | + .It Ev NODE_SKIP_PLATFORM_CHECK | ||
| 569 | + When set to | ||
| 570 | + .Ar 1 , | ||
| 571 | + the check for a supported platform is skipped during Node.js startup. | ||
| 572 | + Node.js might not execute correctly. | ||
| 573 | + Any issues encountered on unsupported platforms will not be fixed. | ||
| 574 | + . | ||
| 568 | 575 | .It Ev NODE_TLS_REJECT_UNAUTHORIZED | |
| 569 | 576 | When set to | |
| 570 | 577 | .Ar 0 , | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -27,13 +27,25 @@ | |||
| 27 | 27 | #include <VersionHelpers.h> | |
| 28 | 28 | #include <WinError.h> | |
| 29 | 29 | ||
| 30 | + #define SKIP_CHECK_VAR "NODE_SKIP_PLATFORM_CHECK" | ||
| 31 | + #define SKIP_CHECK_SIZE 1 | ||
| 32 | + #define SKIP_CHECK_VALUE "1" | ||
| 33 | + | ||
| 30 | 34 | int wmain(int argc, wchar_t* wargv[]) { | |
| 31 | 35 | // Windows Server 2012 (not R2) is supported until 10/10/2023, so we allow it | |
| 32 | 36 | // to run in the experimental support tier. | |
| 37 | + char buf[SKIP_CHECK_SIZE + 1]; | ||
| 33 | 38 | if (!IsWindows8Point1OrGreater() && | |
| 34 | - !(IsWindowsServer() && IsWindows8OrGreater())) { | ||
| 35 | - fprintf(stderr, "This application is only supported on Windows 8.1, " | ||
| 36 | - "Windows Server 2012 R2, or higher."); | ||
| 39 | + !(IsWindowsServer() && IsWindows8OrGreater()) && | ||
| 40 | + (GetEnvironmentVariableA(SKIP_CHECK_VAR, buf, sizeof(buf)) != | ||
| 41 | + SKIP_CHECK_SIZE || | ||
| 42 | + strncmp(buf, SKIP_CHECK_VALUE, SKIP_CHECK_SIZE + 1) != 0)) { | ||
| 43 | + fprintf(stderr, "Node.js is only supported on Windows 8.1, Windows " | ||
| 44 | + "Server 2012 R2, or higher.\n" | ||
| 45 | + "Setting the " SKIP_CHECK_VAR " environment variable " | ||
| 46 | + "to 1 skips this\ncheck, but Node.js might not execute " | ||
| 47 | + "correctly. Any issues encountered on\nunsupported " | ||
| 48 | + "platforms will not be fixed."); | ||
| 37 | 49 | exit(ERROR_EXE_MACHINE_TYPE_MISMATCH); | |
| 38 | 50 | } | |
| 39 | 51 | ||
0 commit comments