tools: add `console` to the list of restricted globals · nodejs/node@0f4f2dd · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0f4f2dd

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

bengl

committed

tools: add console to the list of restricted globals

PR-URL: #42012 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>

1 parent 10ca3bb commit 0f4f2dd
Copy full SHA for 0f4f2dd

3 files changed

+6-5Lines changed: 6 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • .eslintrc.yaml
  • internal
    • freeze_intrinsics.js
    • v8_prof_polyfill.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/.eslintrc.yaml‎

Copy file name to clipboardExpand all lines: lib/.eslintrc.yaml

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -91,6 +91,8 @@ rules:
91	91	message: Use `const { clearInterval } = require('timers');` instead of the global.
92	92	- name: clearTimeout
93	93	message: Use `const { clearTimeout } = require('timers');` instead of the global.
	94	+ - name: console
	95	+ message: Use `const { console } = require('internal/console/global');` instead of the global.
94	96	- name: crypto
95	97	message: Use `const { crypto } = require('internal/crypto/webcrypto');` instead of the global.
96	98	- name: Crypto

Collapse file

‎lib/internal/freeze_intrinsics.js‎

Copy file name to clipboardExpand all lines: lib/internal/freeze_intrinsics.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -19,7 +19,6 @@
19	19	// https://github.com/google/caja/blob/HEAD/src/com/google/caja/ses/repairES5.js
20	20	// https://github.com/tc39/proposal-ses/blob/e5271cc42a257a05dcae2fd94713ed2f46c08620/shim/src/freeze.js
21	21
22		- /* global console */
23	22	'use strict';
24	23
25	24	const {
@@ -133,6 +132,8 @@ const {
133	132	} = globalThis;
134	133
135	134	module.exports = function() {
	135	+ const { Console } = require('internal/console/constructor');
	136	+ const { console } = require('internal/console/global');
136	137	const {
137	138	clearImmediate,
138	139	clearInterval,
@@ -216,7 +217,7 @@ module.exports = function() {
216	217	PromisePrototype, // 27.2
217	218
218	219	// Other APIs / Web Compatibility
219		- console.Console.prototype,
	220	+ Console.prototype,
220	221	WebAssembly.Module.prototype,
221	222	WebAssembly.Instance.prototype,
222	223	WebAssembly.Table.prototype,

Collapse file

‎lib/internal/v8_prof_polyfill.js‎

Copy file name to clipboardExpand all lines: lib/internal/v8_prof_polyfill.js

+1-3Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -27,7 +27,7 @@
27	27
28	28	'use strict';
29	29
30		- /* eslint-disable node-core/prefer-primordials */
	30	+ /* eslint-disable node-core/prefer-primordials, no-restricted-globals */
31	31	/* global console */
32	32
33	33	module.exports = { versionCheck };
@@ -73,7 +73,6 @@ function read(fileName) {
73	73	}
74	74	const quit = process.exit;
75	75	// Polyfill "readline()".
76		- // eslint-disable-next-line no-restricted-globals
77	76	const logFile = globalThis.arguments[globalThis.arguments.length - 1];
78	77	try {
79	78	fs.accessSync(logFile);
@@ -163,7 +162,6 @@ function macCppfiltNm(out) {
163	162	});
164	163	}
165	164
166		- // eslint-disable-next-line no-restricted-globals
167	165	Object.assign(globalThis, {
168	166	os,
169	167	print,

0 commit comments

Comments

0 (0)