FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tls: change loop var to let · nodejs/node@0f7281a · GitHub

/ node Public

Commit 0f7281a

Browse files
Xavier-Redondo
authored and
MylesBorins
committed
tls: change loop var to let
PR-URL: #30445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 351ee64 commit 0f7281a

2 files changed

Lines changed: 36 additions & 36 deletions

File tree

‎lib/internal/tls.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const { Object } = primordials;
77
function parseCertString(s) {
88
const out = Object.create(null);
99
const parts = s.split('\n');
10-
for (var i = 0, len = parts.length; i < len; i++) {
10+
for (let i = 0, len = parts.length; i < len; i++) {
1111
const sepIndex = parts[i].indexOf('=');
1212
if (sepIndex > 0) {
1313
const key = parts[i].slice(0, sepIndex);

‎lib/internal/url.js‎

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ class URLSearchParams {
165165
// Need to use reflection APIs for full spec compliance.
166166
this[searchParams] = [];
167167
const keys = Reflect.ownKeys(init);
168-
for (var i = 0; i < keys.length; i++) {
168+
for (let i = 0; i < keys.length; i++) {
169169
const key = keys[i];
170170
const desc = Reflect.getOwnPropertyDescriptor(init, key);
171171
if (desc !== undefined && desc.enumerable) {
@@ -203,7 +203,7 @@ class URLSearchParams {
203203

204204
const list = this[searchParams];
205205
const output = [];
206-
for (var i = 0; i < list.length; i += 2)
206+
for (let i = 0; i < list.length; i += 2)
207207
output.push(`${innerInspect(list[i])} => ${innerInspect(list[i + 1])}`);
208208

209209
const length = output.reduce(
@@ -390,7 +390,7 @@ Object.defineProperties(URL.prototype, {
390390
...options
391391
};
392392
const ctx = this[context];
393-
var ret = ctx.scheme;
393+
let ret = ctx.scheme;
394394
if (ctx.host !== null) {
395395
ret += '//';
396396
const has_username = ctx.username !== '';
@@ -539,7 +539,7 @@ Object.defineProperties(URL.prototype, {
539539
configurable: true,
540540
get() {
541541
const ctx = this[context];
542-
var ret = ctx.host || '';
542+
let ret = ctx.host || '';
543543
if (ctx.port !== null)
544544
ret += `:${ctx.port}`;
545545
return ret;
@@ -707,13 +707,13 @@ function initSearchParams(url, init) {
707707
// Ref: https://url.spec.whatwg.org/#concept-urlencoded-parser
708708
function parseParams(qs) {
709709
const out = [];
710-
var pairStart = 0;
711-
var lastPos = 0;
712-
var seenSep = false;
713-
var buf = '';
714-
var encoded = false;
715-
var encodeCheck = 0;
716-
var i;
710+
let pairStart = 0;
711+
let lastPos = 0;
712+
let seenSep = false;
713+
let buf = '';
714+
let encoded = false;
715+
let encodeCheck = 0;
716+
let i;
717717
for (i = 0; i < qs.length; ++i) {
718718
const code = qs.charCodeAt(i);
719719

@@ -834,7 +834,7 @@ function serializeParams(array) {
834834
const firstEncodedValue = encodeStr(array[1], noEscape, paramHexTable);
835835
let output = `${firstEncodedParam}=${firstEncodedValue}`;
836836

837-
for (var i = 2; i < len; i += 2) {
837+
for (let i = 2; i < len; i += 2) {
838838
const encodedParam = encodeStr(array[i], noEscape, paramHexTable);
839839
const encodedValue = encodeStr(array[i + 1], noEscape, paramHexTable);
840840
output += `&${encodedParam}=${encodedValue}`;
@@ -876,7 +876,7 @@ function defineIDLClass(proto, classStr, obj) {
876876
function merge(out, start, mid, end, lBuffer, rBuffer) {
877877
const sizeLeft = mid - start;
878878
const sizeRight = end - mid;
879-
var l, r, o;
879+
let l, r, o;
880880

881881
for (l = 0; l < sizeLeft; l++)
882882
lBuffer[l] = out[start + l];
@@ -926,7 +926,7 @@ defineIDLClass(URLSearchParams.prototype, 'URLSearchParams', {
926926

927927
const list = this[searchParams];
928928
name = toUSVString(name);
929-
for (var i = 0; i < list.length;) {
929+
for (let i = 0; i < list.length;) {
930930
const cur = list[i];
931931
if (cur === name) {
932932
list.splice(i, 2);
@@ -947,7 +947,7 @@ defineIDLClass(URLSearchParams.prototype, 'URLSearchParams', {
947947

948948
const list = this[searchParams];
949949
name = toUSVString(name);
950-
for (var i = 0; i < list.length; i += 2) {
950+
for (let i = 0; i < list.length; i += 2) {
951951
if (list[i] === name) {
952952
return list[i + 1];
953953
}
@@ -966,7 +966,7 @@ defineIDLClass(URLSearchParams.prototype, 'URLSearchParams', {
966966
const list = this[searchParams];
967967
const values = [];
968968
name = toUSVString(name);
969-
for (var i = 0; i < list.length; i += 2) {
969+
for (let i = 0; i < list.length; i += 2) {
970970
if (list[i] === name) {
971971
values.push(list[i + 1]);
972972
}
@@ -984,7 +984,7 @@ defineIDLClass(URLSearchParams.prototype, 'URLSearchParams', {
984984

985985
const list = this[searchParams];
986986
name = toUSVString(name);
987-
for (var i = 0; i < list.length; i += 2) {
987+
for (let i = 0; i < list.length; i += 2) {
988988
if (list[i] === name) {
989989
return true;
990990
}
@@ -1007,8 +1007,8 @@ defineIDLClass(URLSearchParams.prototype, 'URLSearchParams', {
10071007
// If there are any name-value pairs whose name is `name`, in `list`, set
10081008
// the value of the first such name-value pair to `value` and remove the
10091009
// others.
1010-
var found = false;
1011-
for (var i = 0; i < list.length;) {
1010+
let found = false;
1011+
for (let i = 0; i < list.length;) {
10121012
const cur = list[i];
10131013
if (cur === name) {
10141014
if (!found) {
@@ -1042,10 +1042,10 @@ defineIDLClass(URLSearchParams.prototype, 'URLSearchParams', {
10421042
// 100 is found through testing.
10431043
// Simple stable in-place insertion sort
10441044
// Derived from v8/src/js/array.js
1045-
for (var i = 2; i < len; i += 2) {
1046-
var curKey = a[i];
1047-
var curVal = a[i + 1];
1048-
var j;
1045+
for (let i = 2; i < len; i += 2) {
1046+
const curKey = a[i];
1047+
const curVal = a[i + 1];
1048+
let j;
10491049
for (j = i - 2; j >= 0; j -= 2) {
10501050
if (a[j] > curKey) {
10511051
a[j + 2] = a[j];
@@ -1061,10 +1061,10 @@ defineIDLClass(URLSearchParams.prototype, 'URLSearchParams', {
10611061
// Bottom-up iterative stable merge sort
10621062
const lBuffer = new Array(len);
10631063
const rBuffer = new Array(len);
1064-
for (var step = 2; step < len; step *= 2) {
1065-
for (var start = 0; start < len - 2; start += 2 * step) {
1066-
var mid = start + step;
1067-
var end = mid + step;
1064+
for (let step = 2; step < len; step *= 2) {
1065+
for (let start = 0; start < len - 2; start += 2 * step) {
1066+
const mid = start + step;
1067+
let end = mid + step;
10681068
end = end < len ? end : len;
10691069
if (mid > end)
10701070
continue;
@@ -1097,7 +1097,7 @@ defineIDLClass(URLSearchParams.prototype, 'URLSearchParams', {
10971097

10981098
let list = this[searchParams];
10991099

1100-
var i = 0;
1100+
let i = 0;
11011101
while (i < list.length) {
11021102
const key = list[i];
11031103
const value = list[i + 1];
@@ -1279,10 +1279,10 @@ const forwardSlashRegEx = /\//g;
12791279

12801280
function getPathFromURLWin32(url) {
12811281
const hostname = url.hostname;
1282-
var pathname = url.pathname;
1283-
for (var n = 0; n < pathname.length; n++) {
1282+
let pathname = url.pathname;
1283+
for (let n = 0; n < pathname.length; n++) {
12841284
if (pathname[n] === '%') {
1285-
var third = pathname.codePointAt(n + 2) | 0x20;
1285+
const third = pathname.codePointAt(n + 2) | 0x20;
12861286
if ((pathname[n + 1] === '2' && third === 102) || // 2f 2F /
12871287
(pathname[n + 1] === '5' && third === 99)) { // 5c 5C \
12881288
throw new ERR_INVALID_FILE_URL_PATH(
@@ -1303,8 +1303,8 @@ function getPathFromURLWin32(url) {
13031303
return `\\\\${domainToUnicode(hostname)}${pathname}`;
13041304
} else {
13051305
// Otherwise, it's a local path that requires a drive letter
1306-
var letter = pathname.codePointAt(1) | 0x20;
1307-
var sep = pathname[2];
1306+
const letter = pathname.codePointAt(1) | 0x20;
1307+
const sep = pathname[2];
13081308
if (letter < CHAR_LOWERCASE_A || letter > CHAR_LOWERCASE_Z || // a..z A..Z
13091309
(sep !== ':')) {
13101310
throw new ERR_INVALID_FILE_URL_PATH('must be absolute');
@@ -1318,9 +1318,9 @@ function getPathFromURLPosix(url) {
13181318
throw new ERR_INVALID_FILE_URL_HOST(platform);
13191319
}
13201320
const pathname = url.pathname;
1321-
for (var n = 0; n < pathname.length; n++) {
1321+
for (let n = 0; n < pathname.length; n++) {
13221322
if (pathname[n] === '%') {
1323-
var third = pathname.codePointAt(n + 2) | 0x20;
1323+
const third = pathname.codePointAt(n + 2) | 0x20;
13241324
if (pathname[n + 1] === '2' && third === 102) {
13251325
throw new ERR_INVALID_FILE_URL_PATH(
13261326
'must not include encoded / characters'

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL