Commit 0f9332a
crypto: use timing-safe comparison in Web Cryptography HMAC and KMAC
Use `CRYPTO_memcmp` instead of `memcmp` in `HMAC` and `KMAC`
Web Cryptography algorithm implementations.
Ref: https://hackerone.com/reports/3533945
PR-URL: nodejs-private/node-private#822
Refs: https://hackerone.com/reports/3533945
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
CVE-ID: CVE-2026-217131 parent 86c0478 commit 0f9332a
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -270,7 +270,8 @@ MaybeLocal<Value> HmacTraits::EncodeOutput(Environment* env, | |||
| 270 | 270 | return Boolean::New( | |
| 271 | 271 | env->isolate(), | |
| 272 | 272 | out->size() > 0 && out->size() == params.signature.size() && | |
| 273 | - memcmp(out->data(), params.signature.data(), out->size()) == 0); | ||
| 273 | + CRYPTO_memcmp( | ||
| 274 | + out->data(), params.signature.data(), out->size()) == 0); | ||
| 274 | 275 | } | |
| 275 | 276 | UNREACHABLE(); | |
| 276 | 277 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -202,7 +202,8 @@ MaybeLocal<Value> KmacTraits::EncodeOutput(Environment* env, | |||
| 202 | 202 | return Boolean::New( | |
| 203 | 203 | env->isolate(), | |
| 204 | 204 | out->size() > 0 && out->size() == params.signature.size() && | |
| 205 | - memcmp(out->data(), params.signature.data(), out->size()) == 0); | ||
| 205 | + CRYPTO_memcmp( | ||
| 206 | + out->data(), params.signature.data(), out->size()) == 0); | ||
| 206 | 207 | } | |
| 207 | 208 | UNREACHABLE(); | |
| 208 | 209 | } | |
0 commit comments