node-api: move NAPI_EXPERIMENTAL definition to gyp file · nodejs/node@0fb9843 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0fb9843

Browse filesBrowse the repository at this point in the historyBrowse files

gabrielschulhof

authored and

richardlau

committed

node-api: move NAPI_EXPERIMENTAL definition to gyp file

PR-URL: #51254 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent 834bbfd commit 0fb9843
Copy full SHA for 0fb9843

2 files changed

+7-5Lines changed: 7 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/js-native-api/test_string
  • binding.gyp
  • test_string.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/js-native-api/test_string/binding.gyp‎

Copy file name to clipboardExpand all lines: test/js-native-api/test_string/binding.gyp

+6-3Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -5,7 +5,10 @@
5	5	"sources": [
6	6	"test_string.c",
7	7	"test_null.c",
8		- ]
9		- }
10		- ]
	8	+ ],
	9	+ "defines": [
	10	+ "NAPI_EXPERIMENTAL",
	11	+ ],
	12	+ },
	13	+ ],
11	14	}

Collapse file

‎test/js-native-api/test_string/test_string.c‎

Copy file name to clipboardExpand all lines: test/js-native-api/test_string/test_string.c

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1,8 +1,7 @@
	1	+ #include <js_native_api.h>
1	2	#include <limits.h> // INT_MAX
2	3	#include <stdlib.h>
3	4	#include <string.h>
4		- #define NAPI_EXPERIMENTAL
5		- #include <js_native_api.h>
6	5	#include "../common.h"
7	6	#include "../entry_point.h"
8	7	#include "test_null.h"

0 commit comments

Comments

0 (0)