doc: fix overstated Date header requirement in response.sendDate · nodejs/node@1020321 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1020321

Browse filesBrowse the repository at this point in the historyBrowse files

authored and

aduh95

committed

doc: fix overstated Date header requirement in response.sendDate

The docs stated "HTTP requires the Date header in responses" which oversimplifies the actual requirement. Per RFC 9110 Section 6.6.1, the Date header is required only in most responses (2xx/3xx/4xx from servers with a clock), not all. Reference the specific RFC section. Fixes: #42619 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> PR-URL: #62206 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 9caa785 commit 1020321
Copy full SHA for 1020321

1 file changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • http.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/http.md‎

Copy file name to clipboardExpand all lines: doc/api/http.md

+3-2Lines changed: 3 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -2301,8 +2301,8 @@ added: v0.7.5
2301	2301	When true, the Date header will be automatically generated and sent in
2302	2302	the response if it is not already present in the headers. Defaults to true.
2303	2303
2304		- This should only be disabled for testing; HTTP requires the Date header
2305		- in responses.
	2304	+ This should only be disabled for testing; the Date header is required in
	2305	+ most HTTP responses (see [RFC 9110 Section 6.6.1][] for details).
2306	2306
2307	2307	### `response.setHeader(name, value)`
2308	2308
@@ -4558,6 +4558,7 @@ const agent2 = new http.Agent({ proxyEnv: process.env });
4558	4558
4559	4559	[Built-in Proxy Support]: #built-in-proxy-support
4560	4560	[RFC 8187]: https://www.rfc-editor.org/rfc/rfc8187.txt
	4561	+ [RFC 9110 Section 6.6.1]: https://www.rfc-editor.org/rfc/rfc9110#section-6.6.1
4561	4562	[`'ERR_HTTP_CONTENT_LENGTH_MISMATCH'`]: errors.md#err_http_content_length_mismatch
4562	4563	[`'checkContinue'`]: #event-checkcontinue
4563	4564	[`'finish'`]: #event-finish

0 commit comments

Comments

0 (0)