src: remove calls to deprecated V8 functions (Equals) · nodejs/node@1025868 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1025868

Browse filesBrowse the repository at this point in the historyBrowse files

targos

committed

src: remove calls to deprecated V8 functions (Equals)

Remove all calls to deprecated V8 functions (here: Value::Equals) inside the code. PR-URL: #22665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent c4ef170 commit 1025868
Copy full SHA for 1025868

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • process_wrap.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/process_wrap.cc‎

Copy file name to clipboardExpand all lines: src/process_wrap.cc

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -109,9 +109,9 @@ class ProcessWrap : public HandleWrap {
109	109	Local<Value> type =
110	110	stdio->Get(context, env->type_string()).ToLocalChecked();
111	111
112		- if (type->Equals(env->ignore_string())) {
	112	+ if (type->StrictEquals(env->ignore_string())) {
113	113	options->stdio[i].flags = UV_IGNORE;
114		- } else if (type->Equals(env->pipe_string())) {
	114	+ } else if (type->StrictEquals(env->pipe_string())) {
115	115	options->stdio[i].flags = static_cast<uv_stdio_flags>(
116	116	UV_CREATE_PIPE | UV_READABLE_PIPE | UV_WRITABLE_PIPE);
117	117	Local<String> handle_key = env->handle_string();
@@ -121,7 +121,7 @@ class ProcessWrap : public HandleWrap {
121	121	options->stdio[i].data.stream =
122	122	reinterpret_cast<uv_stream_t*>(
123	123	Unwrap<PipeWrap>(handle)->UVHandle());
124		- } else if (type->Equals(env->wrap_string())) {
	124	+ } else if (type->StrictEquals(env->wrap_string())) {
125	125	Local<String> handle_key = env->handle_string();
126	126	Local<Object> handle =
127	127	stdio->Get(context, handle_key).ToLocalChecked().As<Object>();

0 commit comments

Comments

0 (0)