Commit 103479a
src: use MaybeLocal.ToLocal instead of IsEmpty
This commit suggest using MaybeLocal.ToLocal and passing in the
Local<Function> fn.
The motivation for doing this is that the following
MaybeLocal.ToLocalChecked call can then be avoided.
PR-URL: #33554
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 3032f0f commit 103479a
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -498,10 +498,10 @@ bool InitializePrimordials(Local<Context> context) { | |||
| 498 | 498 | MaybeLocal<Function> maybe_fn = | |
| 499 | 499 | native_module::NativeModuleEnv::LookupAndCompile( | |
| 500 | 500 | context, *module, ¶meters, nullptr); | |
| 501 | - if (maybe_fn.IsEmpty()) { | ||
| 501 | + Local<Function> fn; | ||
| 502 | + if (!maybe_fn.ToLocal(&fn)) { | ||
| 502 | 503 | return false; | |
| 503 | 504 | } | |
| 504 | - Local<Function> fn = maybe_fn.ToLocalChecked(); | ||
| 505 | 505 | MaybeLocal<Value> result = | |
| 506 | 506 | fn->Call(context, Undefined(isolate), arraysize(arguments), arguments); | |
| 507 | 507 | // Execution failed during context creation. | |
0 commit comments