Commit 107c8c0
perf_hooks: move strings to env
Move repeatedly created strings to env
PR-URL: #22401
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent 282a45d commit 107c8c0
2 files changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -147,10 +147,12 @@ struct PackageConfig { | |||
| 147 | 147 | V(dns_soa_string, "SOA") \ | |
| 148 | 148 | V(dns_srv_string, "SRV") \ | |
| 149 | 149 | V(dns_txt_string, "TXT") \ | |
| 150 | + V(duration_string, "duration") \ | ||
| 150 | 151 | V(emit_warning_string, "emitWarning") \ | |
| 151 | 152 | V(exchange_string, "exchange") \ | |
| 152 | 153 | V(encoding_string, "encoding") \ | |
| 153 | 154 | V(entries_string, "entries") \ | |
| 155 | + V(entry_type_string, "entryType") \ | ||
| 154 | 156 | V(env_pairs_string, "envPairs") \ | |
| 155 | 157 | V(errno_string, "errno") \ | |
| 156 | 158 | V(error_string, "error") \ | |
@@ -186,6 +188,7 @@ struct PackageConfig { | |||
| 186 | 188 | V(issuer_string, "issuer") \ | |
| 187 | 189 | V(issuercert_string, "issuerCertificate") \ | |
| 188 | 190 | V(kill_signal_string, "killSignal") \ | |
| 191 | + V(kind_string, "kind") \ | ||
| 189 | 192 | V(mac_string, "mac") \ | |
| 190 | 193 | V(main_string, "main") \ | |
| 191 | 194 | V(max_buffer_string, "maxBuffer") \ | |
@@ -270,6 +273,7 @@ struct PackageConfig { | |||
| 270 | 273 | V(sni_context_string, "sni_context") \ | |
| 271 | 274 | V(source_string, "source") \ | |
| 272 | 275 | V(stack_string, "stack") \ | |
| 276 | + V(start_time_string, "startTime") \ | ||
| 273 | 277 | V(status_string, "status") \ | |
| 274 | 278 | V(stdio_string, "stdio") \ | |
| 275 | 279 | V(subject_string, "subject") \ | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -80,19 +80,19 @@ inline void InitObject(const PerformanceEntry& entry, Local<Object> obj) { | |||
| 80 | 80 | attr) | |
| 81 | 81 | .FromJust(); | |
| 82 | 82 | obj->DefineOwnProperty(context, | |
| 83 | - FIXED_ONE_BYTE_STRING(isolate, "entryType"), | ||
| 83 | + env->entry_type_string(), | ||
| 84 | 84 | String::NewFromUtf8(isolate, | |
| 85 | 85 | entry.type().c_str(), | |
| 86 | 86 | v8::NewStringType::kNormal) | |
| 87 | 87 | .ToLocalChecked(), | |
| 88 | 88 | attr) | |
| 89 | 89 | .FromJust(); | |
| 90 | 90 | obj->DefineOwnProperty(context, | |
| 91 | - FIXED_ONE_BYTE_STRING(isolate, "startTime"), | ||
| 91 | + env->start_time_string(), | ||
| 92 | 92 | Number::New(isolate, entry.startTime()), | |
| 93 | 93 | attr).FromJust(); | |
| 94 | 94 | obj->DefineOwnProperty(context, | |
| 95 | - FIXED_ONE_BYTE_STRING(isolate, "duration"), | ||
| 95 | + env->duration_string(), | ||
| 96 | 96 | Number::New(isolate, entry.duration()), | |
| 97 | 97 | attr).FromJust(); | |
| 98 | 98 | } | |
@@ -249,7 +249,7 @@ void PerformanceGCCallback(Environment* env, void* ptr) { | |||
| 249 | 249 | v8::PropertyAttribute attr = | |
| 250 | 250 | static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontDelete); | |
| 251 | 251 | obj->DefineOwnProperty(context, | |
| 252 | - FIXED_ONE_BYTE_STRING(env->isolate(), "kind"), | ||
| 252 | + env->kind_string(), | ||
| 253 | 253 | Integer::New(env->isolate(), entry->gckind()), | |
| 254 | 254 | attr).FromJust(); | |
| 255 | 255 | PerformanceEntry::Notify(env, entry->kind(), obj); | |
0 commit comments