Commit 109da52
test: deflake test-http-dump-req-when-res-ends.js
On some platforms the `'end'` event might not be emitted because the
socket could be destroyed by the other peer while the client is still
sending the data triggering an error. Use the `'close'` event instead.
PR-URL: #30360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent e4a296c commit 109da52
2 files changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -19,8 +19,6 @@ test-worker-memory: PASS,FLAKY | |||
| 19 | 19 | test-http2-client-upload: PASS,FLAKY | |
| 20 | 20 | # https://github.com/nodejs/node/issues/20750 | |
| 21 | 21 | test-http2-client-upload-reject: PASS,FLAKY | |
| 22 | - # https://github.com/nodejs/node/issues/30011 | ||
| 23 | - test-http-dump-req-when-res-ends: PASS,FLAKY | ||
| 24 | 22 | ||
| 25 | 23 | [$system==linux] | |
| 26 | 24 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -48,8 +48,12 @@ server.listen(0, mustCall(function() { | |||
| 48 | 48 | ||
| 49 | 49 | res.resume(); | |
| 50 | 50 | ||
| 51 | - // Wait for the response. | ||
| 52 | - res.on('end', function() { | ||
| 51 | + // On some platforms the `'end'` event might not be emitted because the | ||
| 52 | + // socket could be destroyed by the other peer while data is still being | ||
| 53 | + // sent. In this case the 'aborted'` event is emitted instead of `'end'`. | ||
| 54 | + // `'close'` is used here because it is always emitted and does not | ||
| 55 | + // invalidate the test. | ||
| 56 | + res.on('close', function() { | ||
| 53 | 57 | server.close(); | |
| 54 | 58 | }); | |
| 55 | 59 | })); | |
0 commit comments