Commit 10f92d1
test: http2 client settings invalid callback
PR-URL: #18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent baf1acc commit 10f92d1
1 file changed
Lines changed: 17 additions & 4 deletions
Lines changed: 17 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -35,13 +35,26 @@ server.listen(0, common.mustCall(() => { | |||
| 35 | 35 | ['enablePush', 0, TypeError], | |
| 36 | 36 | ['enablePush', null, TypeError], | |
| 37 | 37 | ['enablePush', {}, TypeError] | |
| 38 | - ].forEach((i) => { | ||
| 38 | + ].forEach(([name, value, errorType]) => | ||
| 39 | 39 | common.expectsError( | |
| 40 | - () => client.settings({ [i[0]]: i[1] }), | ||
| 40 | + () => client.settings({ [name]: value }), | ||
| 41 | 41 | { | |
| 42 | 42 | code: 'ERR_HTTP2_INVALID_SETTING_VALUE', | |
| 43 | - type: i[2] }); | ||
| 44 | - }); | ||
| 43 | + type: errorType | ||
| 44 | + } | ||
| 45 | + ) | ||
| 46 | + ); | ||
| 47 | + | ||
| 48 | + [1, true, {}, []].forEach((invalidCallback) => | ||
| 49 | + common.expectsError( | ||
| 50 | + () => client.settings({}, invalidCallback), | ||
| 51 | + { | ||
| 52 | + type: TypeError, | ||
| 53 | + code: 'ERR_INVALID_CALLBACK', | ||
| 54 | + message: 'Callback must be a function' | ||
| 55 | + } | ||
| 56 | + ) | ||
| 57 | + ); | ||
| 45 | 58 | ||
| 46 | 59 | client.settings({ maxFrameSize: 1234567 }); | |
| 47 | 60 | ||
0 commit comments