Commit 1109d0b
build: reduce noise from doc target
The doc target currently echos the complete shell command, which might
produces a lot of output. Using this change the actual commands run
are still shown.
Before:
[ -e tools/doc/node_modules/js-yaml/package.json ] || \
[ -e tools/eslint/node_modules/js-yaml/package.json ] || \
if [ -x ./node ]; then \
cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js
install; \
else \
cd tools/doc && node ../.././deps/npm/bin/npm-cli.js
install; \
fi
[ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0
--format=html --template=doc/template.html doc/api/assert.md >
out/doc/api/assert.html || node tools/doc/generate.js
--node-version=v8.0.0 --format=html --template=doc/template.html
doc/api/assert.md > out/doc/api/assert.html
Input file = doc/api/assert.md
After:
[ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0
--format=html --template=doc/template.html doc/api/assert.md >
out/doc/api/assert.html || node tools/doc/generate.js
--node-version=v8.0.0 --format=html --template=doc/template.html
doc/api/assert.md > out/doc/api/assert.html
Input file = doc/api/assert.md
To verify run:
$ make docclean
$ make doc
PR-URL: #9457
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James Snell <jasnell@gmail.com>1 parent 44792f8 commit 1109d0b
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -315,7 +315,7 @@ out/doc/%: doc/% | |||
| 315 | 315 | # check if ./node is actually set, else use user pre-installed binary | |
| 316 | 316 | gen-json = tools/doc/generate.js --format=json $< > $@ | |
| 317 | 317 | out/doc/api/%.json: doc/api/%.md | |
| 318 | - [ -e tools/doc/node_modules/js-yaml/package.json ] || \ | ||
| 318 | + @[ -e tools/doc/node_modules/js-yaml/package.json ] || \ | ||
| 319 | 319 | [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ | |
| 320 | 320 | if [ -x $(NODE) ]; then \ | |
| 321 | 321 | cd tools/doc && ../../$(NODE) ../../$(NPM) install; \ | |
@@ -327,7 +327,7 @@ out/doc/api/%.json: doc/api/%.md | |||
| 327 | 327 | # check if ./node is actually set, else use user pre-installed binary | |
| 328 | 328 | gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html --template=doc/template.html $< > $@ | |
| 329 | 329 | out/doc/api/%.html: doc/api/%.md | |
| 330 | - [ -e tools/doc/node_modules/js-yaml/package.json ] || \ | ||
| 330 | + @[ -e tools/doc/node_modules/js-yaml/package.json ] || \ | ||
| 331 | 331 | [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ | |
| 332 | 332 | if [ -x $(NODE) ]; then \ | |
| 333 | 333 | cd tools/doc && ../../$(NODE) ../../$(NPM) install; \ | |
0 commit comments