util: isEqualBoxedPrimitive: ensure both values are actual boxed Symbols · nodejs/node@112ec73 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 112ec73

Browse filesBrowse the repository at this point in the historyBrowse files

ljharb

authored and

targos

committed

util: isEqualBoxedPrimitive: ensure both values are actual boxed Symbols

... before trying to valueOf them PR-URL: #29029 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 8426077 commit 112ec73
Copy full SHA for 112ec73

1 file changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/util
  • comparisons.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/util/comparisons.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/comparisons.js

+5-2Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -98,8 +98,11 @@ function isEqualBoxedPrimitive(val1, val2) {
98	98	return isBigIntObject(val2) &&
99	99	BigIntPrototype.valueOf(val1) === BigIntPrototype.valueOf(val2);
100	100	}
101		- return isSymbolObject(val2) &&
102		- SymbolPrototype.valueOf(val1) === SymbolPrototype.valueOf(val2);
	101	+ if (isSymbolObject(val1)) {
	102	+ return isSymbolObject(val2) &&
	103	+ SymbolPrototype.valueOf(val1) === SymbolPrototype.valueOf(val2);
	104	+ }
	105	+ return false;
103	106	}
104	107
105	108	// Notes: Type tags are historical [[Class]] properties that can be set by

0 commit comments

Comments

0 (0)