Commit 114e088
diagnostics_channel: fix last subscriber removal
When iterating over diagnostics channel subscribers, assume their count
is zero if the list of subscribers becomes undefined, because there may
be only one subscriber which may unsubscribe itself as part of its
onMessage handler.
Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
PR-URL: #48933
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>1 parent d4398d4 commit 114e088
2 files changed
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -136,7 +136,7 @@ class ActiveChannel { | |||
| 136 | 136 | } | |
| 137 | 137 | ||
| 138 | 138 | publish(data) { | |
| 139 | - for (let i = 0; i < this._subscribers.length; i++) { | ||
| 139 | + for (let i = 0; i < (this._subscribers?.length || 0); i++) { | ||
| 140 | 140 | try { | |
| 141 | 141 | const onMessage = this._subscribers[i]; | |
| 142 | 142 | onMessage(data, this.name); | |
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,14 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + | ||
| 3 | + const common = require('../common'); | ||
| 4 | + const dc = require('node:diagnostics_channel'); | ||
| 5 | + | ||
| 6 | + const channel_name = 'test:channel'; | ||
| 7 | + const published_data = 'some message'; | ||
| 8 | + | ||
| 9 | + const onMessageHandler = common.mustCall(() => dc.unsubscribe(channel_name, onMessageHandler)); | ||
| 10 | + | ||
| 11 | + dc.subscribe(channel_name, onMessageHandler); | ||
| 12 | + | ||
| 13 | + // This must not throw. | ||
| 14 | + dc.channel(channel_name).publish(published_data); | ||
0 commit comments