Commit 11b82de
test: use strict mode in global setters test
test-global-setters.js was added in
#26882 and hasn't been modified
since. It appears that it avoids strict mode so that unscoped
identifiers are treated as globals, but that's true in strict mode too.
(In sloppy mode, an assignment to an undefined identifier will create a
global, but that's not what this test does. In strict mode, those
assignments will throw an error, which would seem to be what we would
want.)
PR-URL: #56742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>1 parent b0ab483 commit 11b82de
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,4 +1,10 @@ | |||
| 1 | - /* eslint-disable strict */ | ||
| 1 | + // When setters and getters were added for global.process and global.Buffer to | ||
| 2 | + // create a deprecation path for them in ESM, this test was added to make sure | ||
| 3 | + // the setters and getters behaved as expected. | ||
| 4 | + // Ref: https://github.com/nodejs/node/pull/26882 | ||
| 5 | + // Ref: https://github.com/nodejs/node/pull/26334 | ||
| 6 | + | ||
| 7 | + 'use strict'; | ||
| 2 | 8 | require('../common'); | |
| 3 | 9 | const assert = require('assert'); | |
| 4 | 10 | const _process = require('process'); | |
0 commit comments