Commit 124a01d
lib: use full URL to GitHub issues in comments
Don't assume the reader of the code will know where to find the issue
tracker. Provide the full URL. This is especially important if the
issue tracker should move again.
PR-URL: #34686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 77bbd73 commit 124a01d
2 files changed
Lines changed: 8 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -201,7 +201,8 @@ function initEventTarget(self) { | |||
| 201 | 201 | ||
| 202 | 202 | class EventTarget { | |
| 203 | 203 | // Used in checking whether an object is an EventTarget. This is a well-known | |
| 204 | - // symbol as EventTarget may be used cross-realm. See discussion in #33661. | ||
| 204 | + // symbol as EventTarget may be used cross-realm. | ||
| 205 | + // Ref: https://github.com/nodejs/node/pull/33661 | ||
| 205 | 206 | static [kIsEventTarget] = true; | |
| 206 | 207 | ||
| 207 | 208 | constructor() { | |
@@ -520,8 +521,8 @@ function validateEventListenerOptions(options) { | |||
| 520 | 521 | // Test whether the argument is an event object. This is far from a fool-proof | |
| 521 | 522 | // test, for example this input will result in a false positive: | |
| 522 | 523 | // > isEventTarget({ constructor: EventTarget }) | |
| 523 | - // It stands in its current implementation as a compromise. For the relevant | ||
| 524 | - // discussion, see #33661. | ||
| 524 | + // It stands in its current implementation as a compromise. | ||
| 525 | + // Ref: https://github.com/nodejs/node/pull/33661 | ||
| 525 | 526 | function isEventTarget(obj) { | |
| 526 | 527 | return obj && obj.constructor && obj.constructor[kIsEventTarget]; | |
| 527 | 528 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -204,7 +204,8 @@ function onStreamRead(arrayBuffer) { | |||
| 204 | 204 | } | |
| 205 | 205 | ||
| 206 | 206 | if (nread !== UV_EOF) { | |
| 207 | - // #34375 CallJSOnreadMethod expects the return value to be a buffer. | ||
| 207 | + // CallJSOnreadMethod expects the return value to be a buffer. | ||
| 208 | + // Ref: https://github.com/nodejs/node/pull/34375 | ||
| 208 | 209 | stream.destroy(errnoException(nread, 'read')); | |
| 209 | 210 | return; | |
| 210 | 211 | } | |
@@ -224,7 +225,8 @@ function onStreamRead(arrayBuffer) { | |||
| 224 | 225 | if (handle.readStop) { | |
| 225 | 226 | const err = handle.readStop(); | |
| 226 | 227 | if (err) { | |
| 227 | - // #34375 CallJSOnreadMethod expects the return value to be a buffer. | ||
| 228 | + // CallJSOnreadMethod expects the return value to be a buffer. | ||
| 229 | + // Ref: https://github.com/nodejs/node/pull/34375 | ||
| 228 | 230 | stream.destroy(errnoException(err, 'read')); | |
| 229 | 231 | return; | |
| 230 | 232 | } | |
0 commit comments