src: remove unnecessary shadowed functions on Utf8Value & BufferValue · nodejs/node@1289ef8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1289ef8

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

aduh95

committed

src: remove unnecessary shadowed functions on Utf8Value & BufferValue

Both of these are already implemented on the superclass. PR-URL: #60056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

1 parent d1fb8a5 commit 1289ef8
Copy full SHA for 1289ef8

1 file changed

-9Lines changed: 0 additions & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • util.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/util.h‎

Copy file name to clipboardExpand all lines: src/util.h

-9Lines changed: 0 additions & 9 deletions

Original file line number	Diff line number	Diff line change
@@ -552,11 +552,6 @@ class Utf8Value : public MaybeStackBuffer<char> {
552	552	public:
553	553	explicit Utf8Value(v8::Isolate* isolate, v8::Local<v8::Value> value);
554	554
555		- inline std::string ToString() const { return std::string(out(), length()); }
556		- inline std::string_view ToStringView() const {
557		- return std::string_view(out(), length());
558		- }
559		-
560	555	inline bool operator==(const char* a) const { return strcmp(out(), a) == 0; }
561	556	inline bool operator!=(const char* a) const { return !(*this == a); }
562	557	};
@@ -570,10 +565,6 @@ class BufferValue : public MaybeStackBuffer<char> {
570	565	public:
571	566	explicit BufferValue(v8::Isolate* isolate, v8::Local<v8::Value> value);
572	567
573		- inline std::string ToString() const { return std::string(out(), length()); }
574		- inline std::string_view ToStringView() const {
575		- return std::string_view(out(), length());
576		- }
577	568	inline std::u8string_view ToU8StringView() const {
578	569	return std::u8string_view(reinterpret_cast<const char8_t*>(out()),
579	570	length());

0 commit comments

Comments

0 (0)