Commit 1296a68
test: fix flaky test-inspector
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.
PR-URL: #9727
Fixes: #8804
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>1 parent c5e806c commit 1296a68
2 files changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -286,7 +286,7 @@ TestSession.prototype.disconnect = function(childDone) { | |||
| 286 | 286 | this.expectClose_ = true; | |
| 287 | 287 | this.harness_.childInstanceDone = | |
| 288 | 288 | this.harness_.childInstanceDone || childDone; | |
| 289 | - this.socket_.end(); | ||
| 289 | + this.socket_.destroy(); | ||
| 290 | 290 | console.log('[test]', 'Connection terminated'); | |
| 291 | 291 | callback(); | |
| 292 | 292 | }); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,4 +7,3 @@ prefix inspector | |||
| 7 | 7 | [true] # This section applies to all platforms | |
| 8 | 8 | ||
| 9 | 9 | [$system==win32] | |
| 10 | - test-inspector : PASS,FLAKY | ||
0 commit comments