node-api: remove unused mark_arraybuffer_as_untransferable · nodejs/node@12f0fa3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 12f0fa3

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

targos

committed

node-api: remove unused mark_arraybuffer_as_untransferable

napi_create_external_arraybuffer creates the arraybuffer with node::Buffer, which already marks the buffer as untransferable. The napi_env__::mark_arraybuffer_as_untransferable is not used anymore. PR-URL: #47557 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent e8ea834 commit 12f0fa3
Copy full SHA for 12f0fa3

3 files changed

-13Lines changed: 0 additions & 13 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • js_native_api_v8.h
  • node_api.cc
  • node_api_internals.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/js_native_api_v8.h‎

Copy file name to clipboardExpand all lines: src/js_native_api_v8.h

-4Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -66,10 +66,6 @@ struct napi_env__ {
66	66	}
67	67
68	68	virtual bool can_call_into_js() const { return true; }
69		- virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable(
70		- v8::Local<v8::ArrayBuffer> ab) const {
71		- return v8::Just(true);
72		- }
73	69
74	70	static inline void HandleThrow(napi_env env, v8::Local<v8::Value> value) {
75	71	if (env->terminatedOrTerminating()) {

Collapse file

‎src/node_api.cc‎

Copy file name to clipboardExpand all lines: src/node_api.cc

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -35,13 +35,6 @@ bool node_napi_env__::can_call_into_js() const {
35	35	return node_env()->can_call_into_js();
36	36	}
37	37
38		- v8::Maybe<bool> node_napi_env__::mark_arraybuffer_as_untransferable(
39		- v8::Local<v8::ArrayBuffer> ab) const {
40		- return ab->SetPrivate(context(),
41		- node_env()->untransferable_object_private_symbol(),
42		- v8::True(isolate));
43		- }
44		-
45	38	void node_napi_env__::CallFinalizer(napi_finalize cb, void* data, void* hint) {
46	39	CallFinalizer<true>(cb, data, hint);
47	40	}

Collapse file

‎src/node_api_internals.h‎

Copy file name to clipboardExpand all lines: src/node_api_internals.h

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -13,8 +13,6 @@ struct node_napi_env__ : public napi_env__ {
13	13	const std::string& module_filename);
14	14
15	15	bool can_call_into_js() const override;
16		- v8::Maybe<bool> mark_arraybuffer_as_untransferable(
17		- v8::Local<v8::ArrayBuffer> ab) const override;
18	16	void CallFinalizer(napi_finalize cb, void* data, void* hint) override;
19	17	template <bool enforceUncaughtExceptionPolicy>
20	18	void CallFinalizer(napi_finalize cb, void* data, void* hint);

0 commit comments

Comments

0 (0)