Commit 1389a4f
test: fix flaky test-preload
Use `close` event rather than `exit` event to make sure all output has
been received before checking assertions.
PR-URL: #6728
Fixes: #6722
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent adb2d61 commit 1389a4f
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -81,7 +81,7 @@ var stdinStdout = ''; | |||
| 81 | 81 | stdinProc.stdout.on('data', function(d) { | |
| 82 | 82 | stdinStdout += d; | |
| 83 | 83 | }); | |
| 84 | - stdinProc.on('exit', function(code) { | ||
| 84 | + stdinProc.on('close', function(code) { | ||
| 85 | 85 | assert.equal(code, 0); | |
| 86 | 86 | assert.equal(stdinStdout, 'A\nhello\n'); | |
| 87 | 87 | }); | |
@@ -97,7 +97,7 @@ var replStdout = ''; | |||
| 97 | 97 | replProc.stdout.on('data', function(d) { | |
| 98 | 98 | replStdout += d; | |
| 99 | 99 | }); | |
| 100 | - replProc.on('exit', function(code) { | ||
| 100 | + replProc.on('close', function(code) { | ||
| 101 | 101 | assert.equal(code, 0); | |
| 102 | 102 | const output = [ | |
| 103 | 103 | 'A', | |
0 commit comments