FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove unnecessary noop function args to `mustNotCall()` · nodejs/node@13ac0a5 · GitHub

/ node Public

Commit 13ac0a5

Browse files
aduh95
authored and
ruyadorno
committed
test: remove unnecessary noop function args to mustNotCall()
PR-URL: #48513 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 786fbdb commit 13ac0a5

14 files changed

Lines changed: 17 additions & 18 deletions

‎test/.eslintrc.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ rules:
4747
message: Use Number.isNaN() instead of the global isNaN() function.
4848
- selector: VariableDeclarator > CallExpression:matches([callee.name='debuglog'], [callee.property.name='debuglog']):not([arguments.0.value='test'])
4949
message: Use 'test' as debuglog value in tests.
50-
- selector: CallExpression:matches([callee.object.name="common"][callee.property.name=/^mustCall/],[callee.name="mustCall"],[callee.name="mustCallAtLeast"])>:first-child[type=/FunctionExpression$/][body.body.length=0]
50+
- selector: CallExpression:matches([callee.object.name="common"][callee.property.name=/^must(Not)?Call/],[callee.name="mustCall"],[callee.name="mustCallAtLeast"],[callee.name="mustNotCall"])>:first-child[type=/FunctionExpression$/][body.body.length=0]
5151
message: Do not use an empty function, omit the parameter altogether.
5252

5353
# Custom rules in tools/eslint-rules

‎test/parallel/test-child-process-execfile.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const execOpts = { encoding: 'utf8', shell: true };
8484
// Verify that if something different than Abortcontroller.signal
8585
// is passed, ERR_INVALID_ARG_TYPE is thrown
8686
assert.throws(() => {
87-
const callback = common.mustNotCall(() => {});
87+
const callback = common.mustNotCall();
8888

8989
execFile(process.execPath, [echoFixture, 0], { signal: 'hello' }, callback);
9090
}, { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError' });

‎test/parallel/test-fs-promises-readfile.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ async function validateWrongSignalParam() {
6464
// is passed, ERR_INVALID_ARG_TYPE is thrown
6565

6666
await assert.rejects(async () => {
67-
const callback = common.mustNotCall(() => {});
67+
const callback = common.mustNotCall();
6868
await readFile(fn, { signal: 'hello' }, callback);
6969
}, { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError' });
7070

‎test/parallel/test-fs-readfile.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ for (const e of fileInfo) {
9595
// Verify that if something different than Abortcontroller.signal
9696
// is passed, ERR_INVALID_ARG_TYPE is thrown
9797
assert.throws(() => {
98-
const callback = common.mustNotCall(() => {});
98+
const callback = common.mustNotCall();
9999
fs.readFile(fileInfo[0].name, { signal: 'hello' }, callback);
100100
}, { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError' });
101101
}

‎test/parallel/test-http2-client-http1-server.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const http2 = require('http2');
1111
const { NghttpError } = require('internal/http2/util');
1212

1313
// Creating an http1 server here...
14-
const server = http.createServer(common.mustNotCall(() => {}))
14+
const server = http.createServer(common.mustNotCall())
1515
.on('clientError', common.mustCall((error, socket) => {
1616
assert.strictEqual(error.code, 'HPE_PAUSED_H2_UPGRADE');
1717
assert.strictEqual(error.bytesParsed, 24);

‎test/parallel/test-https-agent-session-injection.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const server = https.createServer(options, function(req, res) {
3232
path: '/',
3333
ca,
3434
servername: 'nodejs.org',
35-
}, common.mustNotCall(() => {}));
35+
}, common.mustNotCall());
3636

3737
req.on('error', common.mustCall((err) => {
3838
assert.strictEqual(
@@ -45,7 +45,7 @@ const server = https.createServer(options, function(req, res) {
4545
path: '/',
4646
ca,
4747
servername: 'nodejs.org',
48-
}, common.mustNotCall(() => {}));
48+
}, common.mustNotCall());
4949

5050
second.on('error', common.mustCall((err) => {
5151
server.close();

‎test/parallel/test-readline-interface.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1054,8 +1054,7 @@ for (let i = 0; i < 12; i++) {
10541054
rli.question('foo?', common.mustCall((answer) => {
10551055
assert.strictEqual(answer, 'baz');
10561056
}));
1057-
rli.question('bar?', common.mustNotCall(() => {
1058-
}));
1057+
rli.question('bar?', common.mustNotCall());
10591058
rli.write('baz\n');
10601059
rli.close();
10611060
}

‎test/parallel/test-stream-filter.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ const { setTimeout } = require('timers/promises');
169169
{
170170
const stream = Readable.from([1, 2, 3, 4, 5]);
171171
Object.defineProperty(stream, 'map', {
172-
value: common.mustNotCall(() => {}),
172+
value: common.mustNotCall(),
173173
});
174174
// Check that map isn't getting called.
175175
stream.filter(() => true);

‎test/parallel/test-stream-flatMap.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ function oneTo5() {
124124
{
125125
const stream = oneTo5();
126126
Object.defineProperty(stream, 'map', {
127-
value: common.mustNotCall(() => {}),
127+
value: common.mustNotCall(),
128128
});
129129
// Check that map isn't getting called.
130130
stream.flatMap(() => true);

‎test/parallel/test-stream-forEach.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ const { once } = require('events');
132132
{
133133
const stream = Readable.from([1, 2, 3, 4, 5]);
134134
Object.defineProperty(stream, 'map', {
135-
value: common.mustNotCall(() => {}),
135+
value: common.mustNotCall(),
136136
});
137137
// Check that map isn't getting called.
138138
stream.forEach(() => true);

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL