Commit 13cace1
test: fix helper-debugger-repl.js
The test `debugger/test-debugger-repl-break-in-module` (and probably
others) was failing because the handshake message for debugging is no
longer `listening on port <port>` but is instead `listening on
<address>:<port>`.
This change makes the check less strict so as to hopefully future-proof
it at least a little bit against subsequent changes.
This test failure is not caught in CI because currently debugger tests
are not run in CI.
PR-URL: #9486
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>1 parent aebbc96 commit 13cace1
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -108,7 +108,7 @@ function addTest(input, output) { | |||
| 108 | 108 | } | |
| 109 | 109 | ||
| 110 | 110 | var handshakeLines = [ | |
| 111 | - /listening on port \d+/, | ||
| 111 | + /listening on /, | ||
| 112 | 112 | /connecting.* ok/ | |
| 113 | 113 | ]; | |
| 114 | 114 | ||
0 commit comments