Commit 13fb05e
crypto: handle unsupported AES ciphers in webcrypto
Refs: electron/electron#36256
PR-URL: #45321
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>1 parent 8e7f9de commit 13fb05e
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -556,7 +556,10 @@ Maybe<bool> AESCipherTraits::AdditionalConfig( | |||
| 556 | 556 | } | |
| 557 | 557 | ||
| 558 | 558 | params->cipher = EVP_get_cipherbynid(cipher_nid); | |
| 559 | - CHECK_NOT_NULL(params->cipher); | ||
| 559 | + if (params->cipher == nullptr) { | ||
| 560 | + THROW_ERR_CRYPTO_UNKNOWN_CIPHER(env); | ||
| 561 | + return Nothing<bool>(); | ||
| 562 | + } | ||
| 560 | 563 | ||
| 561 | 564 | if (params->iv.size() < | |
| 562 | 565 | static_cast<size_t>(EVP_CIPHER_iv_length(params->cipher))) { | |
0 commit comments