Commit 145b668
module: move unnecessary work for early return
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.
PR-URL: #3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>1 parent f28a640 commit 145b668
1 file changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -126,19 +126,18 @@ function tryExtensions(p, exts) { | |||
| 126 | 126 | ||
| 127 | 127 | var warned = false; | |
| 128 | 128 | Module._findPath = function(request, paths) { | |
| 129 | - var exts = Object.keys(Module._extensions); | ||
| 130 | - | ||
| 131 | 129 | if (path.isAbsolute(request)) { | |
| 132 | 130 | paths = ['']; | |
| 133 | 131 | } | |
| 134 | 132 | ||
| 135 | - var trailingSlash = (request.slice(-1) === '/'); | ||
| 136 | - | ||
| 137 | 133 | var cacheKey = JSON.stringify({request: request, paths: paths}); | |
| 138 | 134 | if (Module._pathCache[cacheKey]) { | |
| 139 | 135 | return Module._pathCache[cacheKey]; | |
| 140 | 136 | } | |
| 141 | 137 | ||
| 138 | + const exts = Object.keys(Module._extensions); | ||
| 139 | + const trailingSlash = request.slice(-1) === '/'; | ||
| 140 | + | ||
| 142 | 141 | // For each path | |
| 143 | 142 | for (var i = 0, PL = paths.length; i < PL; i++) { | |
| 144 | 143 | // Don't search further if path doesn't exist | |
0 commit comments