lib: runtime deprecate access to process.binding('async_wrap') · nodejs/node@1468c9f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 1468c9f

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

committed

lib: runtime deprecate access to process.binding('async_wrap')

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37576 Fixes: #37575 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 parent a8b5cdc commit 1468c9f
Copy full SHA for 1468c9f

1 file changed

+11Lines changed: 11 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/bootstrap
  • loaders.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/bootstrap/loaders.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/loaders.js

+11Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -105,6 +105,10 @@ const internalBindingAllowlist = new SafeSet([
105	105	'zlib',
106	106	]);
107	107
	108	+ const runtimeDeprecatedList = new SafeSet([
	109	+ 'async_wrap',
	110	+ ]);
	111	+
108	112	// Set up process.binding() and process._linkedBinding().
109	113	{
110	114	const bindingObj = ObjectCreate(null);
@@ -114,6 +118,13 @@ const internalBindingAllowlist = new SafeSet([
114	118	// Deprecated specific process.binding() modules, but not all, allow
115	119	// selective fallback to internalBinding for the deprecated ones.
116	120	if (internalBindingAllowlist.has(module)) {
	121	+ if (runtimeDeprecatedList.has(module)) {
	122	+ runtimeDeprecatedList.delete(module);
	123	+ process.emitWarning(
	124	+ `Access to process.binding('${module}') is deprecated.`,
	125	+ 'DeprecationWarning',
	126	+ 'DEP0111');
	127	+ }
117	128	return internalBinding(module);
118	129	}
119	130	// eslint-disable-next-line no-restricted-syntax

0 commit comments

Comments

0 (0)