Commit 1482c44
build: fix make invocation in tools.yml
Be in the correct directory for `make lint-md-rollup`.
PR-URL: #40890
Refs: https://github.com/nodejs/node/runs/4270533399?check_suite_focus=true
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent 4288c6a commit 1482c44
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -35,10 +35,17 @@ jobs: | |||
| 35 | 35 | - id: "lint-md dependencies" | |
| 36 | 36 | run: | | |
| 37 | 37 | cd tools/lint-md | |
| 38 | - NEW_VERSION=$(npm outdated --omit=dev --parseable | cut -d: -f4 | xargs) | ||
| 38 | + npm ci | ||
| 39 | + NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs) | ||
| 39 | 40 | if [ "$NEW_VERSION" != "" ]; then | |
| 40 | 41 | echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV | |
| 41 | - rm -rf package-lock.json node_modules && npm install --ignore-scripts | ||
| 42 | + rm -rf package-lock.json node_modules | ||
| 43 | + # Include $NEW_VERSION to explicitly update the package.json | ||
| 44 | + # entry for the dependency and also so that semver-major updates | ||
| 45 | + # are not skipped. | ||
| 46 | + npm install --ignore-scripts $NEW_VERSION | ||
| 47 | + npm install --ignore-scripts | ||
| 48 | + cd ../.. | ||
| 42 | 49 | make lint-md-rollup | |
| 43 | 50 | fi | |
| 44 | 51 | steps: | |
0 commit comments