Commit 14cb9ea
perf_hooks: remove useless calls in Histogram
Coverity reported some calls that had no effect,
remove them
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41579
Reviewed-By: Yash Ladha <yash@yashladha.in>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent cfaa1e2 commit 14cb9ea
1 file changed
Lines changed: 16 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -159,10 +159,10 @@ void HistogramBase::GetPercentiles(const FunctionCallbackInfo<Value>& args) { | |||
| 159 | 159 | CHECK(args[0]->IsMap()); | |
| 160 | 160 | Local<Map> map = args[0].As<Map>(); | |
| 161 | 161 | (*histogram)->Percentiles([map, env](double key, int64_t value) { | |
| 162 | - map->Set( | ||
| 163 | - env->context(), | ||
| 164 | - Number::New(env->isolate(), key), | ||
| 165 | - Number::New(env->isolate(), static_cast<double>(value))).IsEmpty(); | ||
| 162 | + USE(map->Set( | ||
| 163 | + env->context(), | ||
| 164 | + Number::New(env->isolate(), key), | ||
| 165 | + Number::New(env->isolate(), static_cast<double>(value)))); | ||
| 166 | 166 | }); | |
| 167 | 167 | } | |
| 168 | 168 | ||
@@ -174,10 +174,10 @@ void HistogramBase::GetPercentilesBigInt( | |||
| 174 | 174 | CHECK(args[0]->IsMap()); | |
| 175 | 175 | Local<Map> map = args[0].As<Map>(); | |
| 176 | 176 | (*histogram)->Percentiles([map, env](double key, int64_t value) { | |
| 177 | - map->Set( | ||
| 178 | - env->context(), | ||
| 179 | - Number::New(env->isolate(), key), | ||
| 180 | - BigInt::New(env->isolate(), value)).IsEmpty(); | ||
| 177 | + USE(map->Set( | ||
| 178 | + env->context(), | ||
| 179 | + Number::New(env->isolate(), key), | ||
| 180 | + BigInt::New(env->isolate(), value))); | ||
| 181 | 181 | }); | |
| 182 | 182 | } | |
| 183 | 183 | ||
@@ -589,10 +589,10 @@ void IntervalHistogram::GetPercentiles( | |||
| 589 | 589 | CHECK(args[0]->IsMap()); | |
| 590 | 590 | Local<Map> map = args[0].As<Map>(); | |
| 591 | 591 | (*histogram)->Percentiles([map, env](double key, int64_t value) { | |
| 592 | - map->Set( | ||
| 593 | - env->context(), | ||
| 594 | - Number::New(env->isolate(), key), | ||
| 595 | - Number::New(env->isolate(), static_cast<double>(value))).IsEmpty(); | ||
| 592 | + USE(map->Set( | ||
| 593 | + env->context(), | ||
| 594 | + Number::New(env->isolate(), key), | ||
| 595 | + Number::New(env->isolate(), static_cast<double>(value)))); | ||
| 596 | 596 | }); | |
| 597 | 597 | } | |
| 598 | 598 | ||
@@ -604,10 +604,10 @@ void IntervalHistogram::GetPercentilesBigInt( | |||
| 604 | 604 | CHECK(args[0]->IsMap()); | |
| 605 | 605 | Local<Map> map = args[0].As<Map>(); | |
| 606 | 606 | (*histogram)->Percentiles([map, env](double key, int64_t value) { | |
| 607 | - map->Set( | ||
| 608 | - env->context(), | ||
| 609 | - Number::New(env->isolate(), key), | ||
| 610 | - BigInt::New(env->isolate(), value)).IsEmpty(); | ||
| 607 | + USE(map->Set( | ||
| 608 | + env->context(), | ||
| 609 | + Number::New(env->isolate(), key), | ||
| 610 | + BigInt::New(env->isolate(), value))); | ||
| 611 | 611 | }); | |
| 612 | 612 | } | |
| 613 | 613 | ||
0 commit comments